Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit nodes when calling .asBool on a Bool #3637

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Don't emit nodes when calling .asBool on a Bool #3637

merged 1 commit into from
Nov 16, 2023

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Backend code generation

Desired Merge Strategy

  • Squash

Release Notes

This results in a slight improvement to emitted FIRRTL quality

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Backend Code Generation Affects backend code generation, will be included in release notes label Nov 16, 2023
@jackkoenig jackkoenig added this to the 3.6.x milestone Nov 16, 2023
seldridge
seldridge approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. No reason to not elide this.

Does the same problem exist for .asUInt(UInt) and .asSInt(SInt)?

@jackkoenig
Copy link
Contributor Author

Nice. No reason to not elide this.

The updated LTLSpec test shows the main motivation, it was really annoying when writing those tests 😂.

Does the same problem exist for .asUInt(UInt) and .asSInt(SInt)?

It does not, good to check though!

@jackkoenig jackkoenig merged commit 2372b1c into main Nov 16, 2023
14 checks passed
@jackkoenig jackkoenig deleted the asbool-no-ops branch November 16, 2023 22:19
@mergify mergify bot added the Backported This PR has been backported label Nov 16, 2023
This was referenced Nov 16, 2023
Merged
Merged
mergify bot added a commit that referenced this pull request Nov 17, 2023
@mergify @jackkoenig
Don't emit nodes when calling .asBool on a Bool (backport #3637) (#3638)
d752cae 
* Don't emit nodes when calling .asBool on a Bool

(cherry picked from commit d5e65a3)

# Conflicts:
#	core/src/main/scala/chisel3/Bits.scala
#	src/test/scala/chiselTests/LTLSpec.scala
#	src/test/scala/chiselTests/VerificationSpec.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Nov 17, 2023
@mergify @jackkoenig
Don't emit nodes when calling .asBool on a Bool (backport #3637) (#3639)
31a50a1 
* Don't emit nodes when calling .asBool on a Bool

(cherry picked from commit d5e65a3)

# Conflicts:
#	src/test/scala/chiselTests/LTLSpec.scala
#	src/test/scala/chiselTests/VerificationSpec.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backend Code Generation Affects backend code generation, will be included in release notes Backported This PR has been backported
Projects
None yet
Milestone
3.6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge